He never won the French Open and was never particularly good on clay, so I can't call him the greatest of all time. He's got the greatest serve and greatest running forehand of all time, and Agassi, his greatest rival, often did bring out the best in Sampras. He was great, but would not have dominated earlier eras before the technology started producing 150 MPH serves.
