Today? McNabb, as he's clearly in his prime. But when you compare the two at their prime, I'd go with Favre. He's much more explosive and can make big plays. But to fair to him, today he's in a team that really lacks talent, especially on defense. Put him on a team with a solid defense, Baltimore, San Diego or Miami, and he still would play very well.