He was after my time as a kid as I was out of college when his long running television show started. I really don't see how he was controversial one way or the other.
I always enjoyed the urban legend that he was a sniper in the army and had killer tattoos on his arms. Snopes.com does a good job squelching that rumor.